Misc cleanup in EditorExportPlatform#110248
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 4, 2025
Merged
Conversation
Member
KoBeWi
commented
Sep 4, 2025
KoBeWi
commented
- Replaced repetitive code in EditorExportPlatform with a helper method
- Replaced macro with constexpr
- Cleaned up includes
- This also required changes in other files
bruvzg
reviewed
Sep 4, 2025
KoBeWi
force-pushed
the
unexpected_include_hell
branch
from
1f1ee21 to
1708ffc
Compare
bruvzg
approved these changes
Sep 4, 2025
Calinou
reviewed
Sep 4, 2025
KoBeWi
force-pushed
the
unexpected_include_hell
branch
from
1708ffc to
1d23d4d
Compare
Contributor
|
Needs rebase |
KoBeWi
force-pushed
the
unexpected_include_hell
branch
from
1d23d4d to
0a4f401
Compare
Contributor
|
Oop, looks like include order got unsorted: index ecc4798..72f33f9 100644
--- a/editor/export/editor_export_preset.cpp
+++ b/editor/export/editor_export_preset.cpp
@@ -31,8 +31,8 @@
#include "editor_export.h"
#include "core/config/project_settings.h"
-#include "editor/settings/editor_settings.h"
#include "core/io/dir_access.h"
+#include "editor/settings/editor_settings.h"
bool EditorExportPreset::_set(const StringName &p_name, const Variant &p_value) {
values[p_name] = p_value;Fixing that should make CI pass |
KoBeWi
force-pushed
the
unexpected_include_hell
branch
from
0a4f401 to
024559c
Compare
Contributor
|
Shoot, now it looks like the |
KoBeWi
force-pushed
the
unexpected_include_hell
branch
from
024559c to
3756758
Compare
KoBeWi
force-pushed
the
unexpected_include_hell
branch
from
3756758 to
90dd171
Compare
KoBeWi
force-pushed
the
unexpected_include_hell
branch
from
90dd171 to
1c1c320
Compare
Repiteo
approved these changes
Nov 3, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.