Image: Make fill method also fill the mipmaps#110247
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 24, 2025
Merged
Image: Make fill method also fill the mipmaps#110247Repiteo merged 1 commit intogodotengine:masterfrom
fill method also fill the mipmaps#110247Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
fire
approved these changes
Sep 6, 2025
Member
fire
left a comment
fire
left a comment
There was a problem hiding this comment.
I think this is correct but I have not checked in a build.
Calinou
approved these changes
Sep 9, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
Testing project: test_pr_110247.zip
| Before | After |
|---|---|
 |
 |
BlueCube3310
force-pushed
the
image-fill-mips
branch
from
8a5cedd to
666ed1b
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
fillmethod also fill the mipmaps of an image. Changes the unit test to account for this case.