Fix shader compilation errors in Compatibility when using depth_texture#110241
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 22, 2025
Merged
Conversation
…ure` Globals were defined too early, which means some uniforms were not available at the point they were defined in.
clayjohn
approved these changes
Sep 4, 2025
clayjohn
added
the
cherrypick:4.5
|
any chance this still makes it into 4.5? |
Member
Author
We're entering RC stage soon, so only critical fixes should make it to 4.5 now. We want to avoid any possible regressions at this point. This can be cherry-picked to 4.5.x in any case. |
Contributor
|
Thanks! |
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Globals were defined too early, which means some uniforms were not available at the point they were defined in.
I tested rendering on the MRP as well as many demo projects, and it works as expected.