Add checks for integer vectors for integer division warning#110240
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 1, 2025
Merged
Add checks for integer vectors for integer division warning#110240Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
kleonc
reviewed
Sep 4, 2025
Remove warnings for invalid Vectori combinations Co-authored-by: kleonc <9283098+kleonc@users.noreply.github.com>
westenral
force-pushed
the
add_int_division_warnings
branch
from
81b7749 to
565e1aa
Compare
kleonc
approved these changes
Sep 4, 2025
Member
kleonc
left a comment
kleonc
left a comment
There was a problem hiding this comment.
Expanding the warning to vectors makes sense, code looks good.
Contributor
|
Thanks! Congratulations on your first merged contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the check for integer division to include
Vector2i,Vector3i, andVector4i, if it is decided that those types should be included in the check.Rect2iwasn't included because it doesn't support division. The implementation is very straightforward for now and simply checks if both the left-hand side and right-hand side are integer-based types.(I'm a newbie; let me know what I missed.)
Fix #110229