X Tutup
Skip to content

Fix invalid suggested file name when saving resource from a scene that hasn't been saved yet#110231

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
fstxz:fix_shader_path
Sep 24, 2025
Merged

Fix invalid suggested file name when saving resource from a scene that hasn't been saved yet#110231
Repiteo merged 1 commit intogodotengine:masterfrom
fstxz:fix_shader_path

Conversation

@fstxz
Copy link
Contributor

@fstxz fstxz commented Sep 3, 2025

Fixes #110038

@fstxz fstxz requested a review from a team September 3, 2025 15:30
@AThousandShips AThousandShips added bug topic:editor topic:shaders cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Sep 3, 2025
@AThousandShips AThousandShips added this to the 4.6 milestone Sep 3, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Sep 3, 2025

Regression from #107943. if (path.is_empty()) was always false after this change.

@fstxz
Copy link
Contributor Author

fstxz commented Sep 3, 2025

@KoBeWi you linked this PR

@KoBeWi
Copy link
Member

KoBeWi commented Sep 3, 2025

Right, fixed.

@fstxz
Copy link
Contributor Author

fstxz commented Sep 3, 2025

Saving resource to a file also has this problem

image

I will update the PR tomorrow.

@fstxz fstxz changed the title Fix invalid shader path when creating it in a scene that hasn't been saved yet Fix invalid suggested file name when saving resource from a scene that hasn't been saved yet Sep 4, 2025
@Repiteo Repiteo merged commit f987cf8 into godotengine:master Sep 24, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 24, 2025

Thanks!

@fstxz fstxz deleted the fix_shader_path branch September 25, 2025 06:30
@akien-mga
Copy link
Member

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Creating a shader in a scene that hasn't been saved yet defaults to an invalid UID-like path

5 participants

X Tutup