X Tutup
Skip to content

Allow all ColorPicker Shapes to expand horizontally#110218

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
mounirtohami:picker-shape-expand
Oct 28, 2025
Merged

Allow all ColorPicker Shapes to expand horizontally#110218
Repiteo merged 1 commit intogodotengine:masterfrom
mounirtohami:picker-shape-expand

Conversation

@WhalesState
Copy link
Contributor

Before:

Screencast.From.2025-09-03.09-18-26.mp4

After:

Screencast.From.2025-09-03.09-19-12.mp4

@WhalesState WhalesState requested a review from a team as a code owner September 3, 2025 06:21
@AThousandShips AThousandShips added this to the 4.x milestone Sep 3, 2025
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stretching rectangular shapes (and centering the rest) definitely make sense.

Swatches container probably should be stretched as well:

Image

@WhalesState
Copy link
Contributor Author

WhalesState commented Sep 3, 2025

Swatches container probably should be stretched as well:

I will soon open another PR fixing the swatches and the recent color presets to use FoldableContainer and to scroll horizontally to reduce the height of the color ColorPicker when there are many colors like this and we can merge both together to fix this issue.

Edit: Swatches uses GridContainer with a fixed size so they can't be expanded unless we make it a FlowContainer or an HBoxContainer + ScrollContainer like the video.

Screencast.From.2025-09-03.12-03-38.mp4

@WhalesState
Copy link
Contributor Author

Honestly, I see this more as a bug fix than a feature proposal.

image

@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Sep 3, 2025
Co-authored-by: Tomasz Chabora <kobewi4e@gmail.com>
@Repiteo Repiteo merged commit 60f6733 into godotengine:master Oct 28, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 28, 2025

Thanks!

@WhalesState WhalesState deleted the picker-shape-expand branch October 30, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup