Remove unused parameter in __constant_get_enum_name/__constant_get_bitfield_name#110206
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 17, 2025
Merged
Conversation
…tfield_name Removed unused String parameter in __constant_get_enum_name() and __constant_get_bitfield_name() to avoid creating/destroying extra Strings.
Calinou
approved these changes
Sep 2, 2025
Member
There was a problem hiding this comment.
Tested locally on a few projects, it works as expected. Code looks good to me.
Binary size (Linux x86_64 release export template with LTO enabled):
- Before: 71,480,352 bytes
- After: 71,287,968 bytes (-192 kB)
Android release APK:
- Before: 73,539,379 bytes
- After: 73,119,011 bytes (-420 kB)
Web release WASM:
- Before: 47,410,554 bytes
- After: 46,930,399 bytes (-480 kB)
Web release WASM gzipped (default level):
- Before: 10,563,664 bytes
- After: 10,534,333 bytes (-29 kB)
The decrease in binary size should be more significant on editor builds, given it has more bindings.
Contributor
|
Thanks! |
ProfessorOctopus
pushed a commit
to ProfessorOctopus/godot
that referenced
this pull request
Sep 17, 2025
…m_bitfield_param Remove unused parameter in `__constant_get_enum_name`/`__constant_get_bitfield_name`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused
Stringparameter in__constant_get_enum_name()and__constant_get_bitfield_name()to avoid creating/destroying extraStrings. Reduces binary size by ~300 KB.