X Tutup
Skip to content

Clamp minimum size of 3D texture view in D3D12.#110203

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
DarioSamo:d3d12-clamp-mipmap
Sep 19, 2025
Merged

Clamp minimum size of 3D texture view in D3D12.#110203
Repiteo merged 1 commit intogodotengine:masterfrom
DarioSamo:d3d12-clamp-mipmap

Conversation

@DarioSamo
Copy link
Contributor

@DarioSamo DarioSamo commented Sep 2, 2025

3D textures that used mipmaps that'd scale the depth of the texture enough to make the bitshift result in a 0 would lead to crashing the driver. Applying the clamp fixes this issue.

Bugsquad edit: Fixes #108552.

@clayjohn clayjohn linked an issue Sep 2, 2025 that may be closed by this pull request
@Calinou Calinou added the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Sep 2, 2025
@Calinou Calinou added this to the 4.5 milestone Sep 2, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@clayjohn clayjohn modified the milestones: 4.5, 4.6 Sep 2, 2025
@clayjohn clayjohn added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Sep 2, 2025
@Repiteo Repiteo merged commit d8a909d into godotengine:master Sep 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 19, 2025

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Baking VoxelGI in D3D12 hangs/crashes Godot on a specific mesh

5 participants

X Tutup