Any chance I could argue for also removing the ERR_FAIL_V_MSG at the bottom of OS_AppleEmbedded::get_processor_name? Maybe we can replace it with a print_verbose instead or something?

Part of the motivation behind reporting #110168 was to hopefully avoid emitting this particular error, as it's proven to be prevalent and annoying for one of our clients, due to them sending all their errors off to an error reporting service.

Since there's no OS.try_get_processor_name or anything, there isn't a whole lot you can do to avoid this error, which basically leaves you having to explicitly filter it out before sending them off to the error reporting service, and since this solution relies on continuously adding new models to this list, it would seem guaranteed that you'll run into this error again eventually.

For what it's worth, Android relies on the default OS::get_processor_name, which just returns an empty string without any error, so I don't think it's too out-of-place to just remove this Couldn't get the CPU model name error altogether and have the fallback be an empty string.

Any chance I could argue for also removing the ERR_FAIL_V_MSG at the bottom of OS_AppleEmbedded::get_processor_name? Maybe we can replace it with a print_verbose instead or something?

I guess this makes sense, there's no benefit from this error, and it will inevitably fail in some conditions (when old versions are used on yet to be released devices).

047a7c5

Seems like something went wrong and commit before I have added latest set of devices got merged, while PR still show as open.

Oops, my bad. Let's re-merge this rebased version then.

Thanks!