Fix rounding error in clustered vertex light culling#110184
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 17, 2025
Merged
Fix rounding error in clustered vertex light culling#110184Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Namey5
force-pushed
the
vertex-lighting-issue
branch
from
f7091c4 to
60a7bed
Compare
clayjohn
added
bug
topic:rendering
cherrypick:4.4
Calinou
approved these changes
Sep 2, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
Contributor
|
Thanks! |
ProfessorOctopus
pushed a commit
to ProfessorOctopus/godot
that referenced
this pull request
Oct 5, 2025
Fix rounding error in clustered vertex light culling
Member
|
Cherry-picked for 4.5.2. |
akien-mga
removed
cherrypick:4.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like there was a rounding error when calculating what clustered light tile to use for off-screen vertices - I've just moved some more of the logic to integer precision to make it a bit more consistent with per-pixel lighting.
Before:
Screencast.From.2025-09-02.09-32-43.mp4
After:
Screencast.From.2025-09-02.09-33-46.mp4