X Tutup
Skip to content

Use placeholder instead of value for tooltips of PROPERTY_HINT_PASSWORD properties.#110164

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:prop_pass
Sep 19, 2025
Merged

Use placeholder instead of value for tooltips of PROPERTY_HINT_PASSWORD properties.#110164
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:prop_pass

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 1, 2025

Fixes #110163

Before:
Screenshot 2025-09-01 at 16 50 57

After:
Screenshot 2025-09-01 at 16 44 39

@bruvzg bruvzg added this to the 4.6 milestone Sep 1, 2025
@bruvzg bruvzg requested a review from a team September 1, 2025 13:51
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@smix8 smix8 added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Sep 5, 2025
@Repiteo Repiteo merged commit 9cb6411 into godotengine:master Sep 19, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 19, 2025

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Password are visible in tooltips of LineEdit with secret enabled

6 participants

X Tutup