X Tutup
Skip to content

Differentiate the suspend button in the Game tab with the Pause button in the editor run bar#110108

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
PiCode9560:suspend-button
Sep 24, 2025
Merged

Differentiate the suspend button in the Game tab with the Pause button in the editor run bar#110108
Repiteo merged 1 commit intogodotengine:masterfrom
PiCode9560:suspend-button

Conversation

@PiCode9560
Copy link
Contributor

@PiCode9560 PiCode9560 commented Aug 30, 2025

Close godotengine/godot-proposals#12990

Added a new icon, and more info on the tooltip.

image

Edit: the image above is from the latest changes.

@PiCode9560 PiCode9560 requested a review from a team as a code owner August 30, 2025 04:32
@PiCode9560 PiCode9560 requested a review from a team August 30, 2025 04:32
@KoBeWi KoBeWi added this to the 4.x milestone Aug 30, 2025
Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Aug 30, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected (also on light theme). Code and icon look good to me.

@PiCode9560
Copy link
Contributor Author

This feature is very small. So can we just add it to 4.5 instead?

@AThousandShips
Copy link
Member

We're approaching the release candidate phase so we will not be adding any new features, this will probably be able to be added in an early 4.6 wave though

@KoBeWi
Copy link
Member

KoBeWi commented Sep 1, 2025

Since it's so small, it could maybe be cherry-picked to 4.5.1.

@Mickeon Mickeon added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Sep 20, 2025
@arkology
Copy link
Contributor

Could someone please put this PR into merge queue? 😄

@KoBeWi
Copy link
Member

KoBeWi commented Sep 24, 2025

It's already in merge queue, along with 259 other PRs. It will take some time to merge everything.

@arkology
Copy link
Contributor

@KoBeWi got it, thanks for information!

@Repiteo Repiteo merged commit de27f3a into godotengine:master Sep 24, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 24, 2025

Thanks!

@Repiteo Repiteo removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Differentiate the suspend button in the Game tab with the Pause button in the editor run bar

8 participants

X Tutup