Divide screen texture by luminance multiplier in compatibility#110004
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 6, 2025
Merged
Divide screen texture by luminance multiplier in compatibility#110004Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Kaleb-Reid
force-pushed
the
divide-luminance
branch
from
234bb8c to
c8017cf
Compare
Kaleb-Reid
force-pushed
the
divide-luminance
branch
from
c8017cf to
8ad335e
Compare
Contributor
Author
|
@clayjohn |
Contributor
|
Thanks! |
clayjohn
added
the
cherrypick:4.5
Member
|
Cherry-picked for 4.5.1. |
akien-mga
removed
the
cherrypick:4.5
Contributor
Author
|
@akien-mga I just realized that this being cherry-picked caused a regression in the 4.5 branch so I made #111438. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile and compatibility both use a luminance multiplier for glow, which has the side effect of making the screen texture dark.
Mobile already worked around this by transparently adding in an extra multiplication when sampling the texture in a shader, but compatibility for some reason didn't.
Fixes #107552