Organize toggle files button logic in shader editor#109998
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 24, 2025
Merged
Organize toggle files button logic in shader editor#109998Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
This was referenced Aug 27, 2025
Calinou
approved these changes
Aug 27, 2025
Member
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
b7e1047 to
23fa9d8
Compare
KoBeWi
approved these changes
Sep 26, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current master, this code is in the toggle files panel case:
It's a bit disorganized for the main shader editor code to know about each language, when an abstract function will do:
This is a prerequisite cleanup to PR #64596, I'm opening a separate PR for this change so it can be reviewed and merged in advance of the rest, making the changes in PR #64596 smaller.