Use regularization flag for LODs of deformable objects to improve appearance post deformation#109992
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 23, 2025
Merged
Conversation
fire
reviewed
Aug 26, 2025
clayjohn
approved these changes
Aug 26, 2025
Member
|
Significant improvement was seen at lod_bias 0.04 GODOT-pull-request-109992.mp4GODOT-stable-4.4.mp4 |
Calinou
reviewed
Aug 26, 2025
Calinou
reviewed
Aug 26, 2025
fire
approved these changes
Aug 26, 2025
Calinou
approved these changes
Sep 10, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Code looks good to me. Remember to squash the last two commits so this can be merged 🙂
zeux
force-pushed
the
simplify-regularize
branch
from
9a8fa9d to
e5b2798
Compare
Contributor
Author
|
Yup, squashed the last two commits here and rebased the dependent PR chain. |
zeux
force-pushed
the
simplify-regularize
branch
from
e5b2798 to
5662819
Compare
This significantly improves LOD quality for skinned objects, especially if the skinned object geometry is very simple (e.g. planar or cylindrical) in bind pose. Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
zeux
force-pushed
the
simplify-regularize
branch
from
5662819 to
92596e3
Compare
BlueCube3310
approved these changes
Sep 22, 2025
Contributor
|
Thanks! |
Member
|
Would it be possible to cherry pick for 4.5? |
fire
added
the
cherrypick:4.5
Member
|
Edit: Dropped cherry-pick, it depends on #109990 which is a feature PR. |
akien-mga
removed
the
cherrypick:4.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84479
Closes #71141
When generating LODs for meshes that use skinning or blend shapes, we now use the new regularization option (available as of meshoptimizer 0.25). This results in the simplifier taking the distance along the original surface into account when computing simplification error, which biases the results to have a more uniform tessellation, accounting for deformation that is unknown at import time. This fixes two instances of severe LOD degradation (above) after a re-import; it also helps more regular character meshes in certain cases, for example here's a before-after on a mesh with a cape that was simplified too much previously (LOD selection exaggerated via project settings, ~same number of triangles before/after):