Expose get_fading_... methods for AnimationNodeStateMachinePlayback#109986
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 28, 2025
Merged
Conversation
SomeRanDev
force-pushed
the
animation_node_state_machine_playback_expansion
branch
from
2560955 to
5dd9444
Compare
SomeRanDev
changed the title
get_fade_... methods for AnimationNodeStateMachinePlaybackget_fading_... methods for AnimationNodeStateMachinePlayback
TokageItLab
approved these changes
Aug 28, 2025
Member
TokageItLab
left a comment
TokageItLab
left a comment
There was a problem hiding this comment.
Expose only getters are definitely safe. It also has consistency with current.
Just a nitpick, but to fix inconsistencies in C++ side, it might be better to rename get_fade_from_xxx() to get_fading_from_xxx(). This should be safe if it's only a change to the C++ functions.
SomeRanDev
force-pushed
the
animation_node_state_machine_playback_expansion
branch
from
3b4d86a to
dc8f7b4
Compare
Contributor
Author
I had the same thought, but I wanted to be conservative with changes! Updated! 👍 |
AThousandShips
approved these changes
Aug 29, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exposes a couple public getter functions from
AnimationNodeStateMachinePlayback.Their original PR (#71284) doesn't mention any reason for them not to be exposed, and I could definitely use them!
get_fading_from_length/get_fading_from_play_positionprovide animation state information for the existingget_fading_from_node.get_fading_length/get_fading_positionprovide information of the animation's runtime "blending" state.