X Tutup
Skip to content

Fix typos and link tutorial in WebRTCPeerConnection docs#109907

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
abrusle:patch-1
Dec 4, 2025
Merged

Fix typos and link tutorial in WebRTCPeerConnection docs#109907
akien-mga merged 1 commit intogodotengine:masterfrom
abrusle:patch-1

Conversation

@abrusle
Copy link
Contributor

@abrusle abrusle commented Aug 23, 2025

Fixed some typos in the description of WebRTCPeerConnection.

@abrusle abrusle requested review from a team as code owners August 23, 2025 12:57
@AThousandShips AThousandShips changed the title Fixed typos in WebRTCPeerConnection.xml Fix typos in WebRTCPeerConnection.xml Aug 23, 2025
@AThousandShips AThousandShips added this to the 4.x milestone Aug 25, 2025
@AThousandShips AThousandShips added cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Aug 25, 2025
- The peer that wants to initiate the connection ([code]A[/code] from now on) creates an offer and sends it to the other peer ([code]B[/code] from now on).
- [code]B[/code] receives the offer, generates an answer, and sends it to [code]A[/code].
- [code]A[/code] and [code]B[/code] then generate and exchange ICE candidates with each other.
After these steps, the connection should be established. Keep on reading or look at the tutorial for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no tutorial in the <tutorials> section; what did they even originally mean 😭

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mickeon Mickeon modified the milestones: 4.x, 4.6 Nov 25, 2025
@Repiteo
Copy link
Contributor

Repiteo commented Dec 3, 2025

Could you squash your commits? See our pull request guidelines for more information

@akien-mga akien-mga changed the title Fix typos in WebRTCPeerConnection.xml Fix typos in WebRTCPeerConnection docs Dec 4, 2025
@akien-mga akien-mga changed the title Fix typos in WebRTCPeerConnection docs Fix typos and link tutorial in WebRTCPeerConnection docs Dec 4, 2025
@akien-mga
Copy link
Member

Squashed and adding a link to the WebRTC tutorial.

@akien-mga akien-mga merged commit fa2be87 into godotengine:master Dec 4, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga removed cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup