GLTF export: use ORM texture for occlusion/metallicRoughnessTexture if it exists#109845
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 4, 2025
Merged
Conversation
fire
reviewed
Aug 22, 2025
nikitalita
force-pushed
the
gltf-use-orm-texture
branch
from
f22b85b to
ff822f5
Compare
Contributor
Author
|
Same here. |
Member
|
I think this PR is good at a glance but I want to give it a detailed review after other related PRs are merged (EDIT: Just PR #109475 remains). |
nikitalita
force-pushed
the
gltf-use-orm-texture
branch
from
ff822f5 to
6334202
Compare
nikitalita
force-pushed
the
gltf-use-orm-texture
branch
6 times, most recently
from
770c52d to
5d414e6
Compare
aaronfranke
reviewed
Oct 21, 2025
nikitalita
force-pushed
the
gltf-use-orm-texture
branch
2 times, most recently
from
fdca71d to
764d98b
Compare
nikitalita
force-pushed
the
gltf-use-orm-texture
branch
from
764d98b to
ec97115
Compare
github-project-automation
bot
moved this from Ready for review
to Done
in Asset Pipeline Issue Triage
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #109475
The GLTF exporter is currently not using the ORM texture (i.e. from an ORMMaterial3D) for the occlusion/metallicRoughnessTexture if it exists; it only attempts to use the individual occlusion/roughness/metallic textures (i.e. from an StandardMaterial3D). This changes it such that if those individual textures don't exist, it attempts to use the ORM texture.