https://xiph.org/vorbis/doc/v-comment.html

Basically, comments are structured like env vars in vorbis, VAR=VALUE. This is how tags are stored (artist, album, etc.), and Godot parses them out for display. When it comes across one that is not formatted like this, it throws a warning.

@nikitalita Can you put that in a comment in the code?

done

I can't re-run the failed jobs

I think this is ready to go.

Looks good, but still needs the commits to be squashed. See our pull request guidelines for more information

I've done that, but I wish I understood why the maintainers of this project forbid "squash and merge".

Is the title of the PR outdated? The code doesn't filter out only in editor builds now

I've done that, but I wish I understood why the maintainers of this project forbid "squash and merge".

For several reasons, one is the workload on our production team (dozens of PRs is a lot to squash and make sure it was done right, considering squashing a single one can be annoying, imagine a dozen), another is that we want a clean history where we have a clear merge commit which means the PR is as is, without other changes, so it can be easily reverted, or cherry picked

We could use "squash and use merge commit" but GitHub doesn't allow that, we also have several maintainers and contributors who sign their commits because downstream consumers need that security, if we only used one type of merge method we'd lose that (squashed commits, or plain merged commits lose their sign information as it is recommitted), and having multiple means of merging things doesn't work with merge queues, and adds a burden to the production team

Is the title of the PR outdated? The code doesn't filter out only in editor builds now

It was a mistake that I made when rebasing on top of master to appease the PR guidelines. It's fixed now.

And there you have the risks of having the production team doing it instead, not being familiar with the PR!

Thanks!