X Tutup
Skip to content

Update POT files when a file is moved or deleted#109802

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
oxeron:fix_pot_files_not_updated
Oct 23, 2025
Merged

Update POT files when a file is moved or deleted#109802
Repiteo merged 1 commit intogodotengine:masterfrom
oxeron:fix_pot_files_not_updated

Conversation

@oxeron
Copy link
Contributor

@oxeron oxeron commented Aug 20, 2025

This should fix missing feature described in #106977

@oxeron oxeron requested a review from a team as a code owner August 20, 2025 13:25
@Calinou Calinou added this to the 4.x milestone Aug 20, 2025
@oxeron
Copy link
Contributor Author

oxeron commented Aug 20, 2025

I had to make another commit to fix linter issue, should I create a new PR with only one commit ?

@YeldhamDev
Copy link
Member

@oxeron oxeron force-pushed the fix_pot_files_not_updated branch from c80b2c6 to f7fe62a Compare August 20, 2025 21:03
@oxeron
Copy link
Contributor Author

oxeron commented Aug 20, 2025

@YeldhamDev thanks for the help, just did it, hope it's ok

@YeldhamDev
Copy link
Member

The commit message is too generic. Try using this PR's name for it instead.

@oxeron oxeron force-pushed the fix_pot_files_not_updated branch from f7fe62a to 52f9bb5 Compare August 21, 2025 04:42
@oxeron
Copy link
Contributor Author

oxeron commented Aug 21, 2025

Done !

Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@YeldhamDev YeldhamDev modified the milestones: 4.x, 4.6 Aug 21, 2025
@oxeron
Copy link
Contributor Author

oxeron commented Aug 21, 2025

Thank you, happy to provide my first PR on the project 🤗

@Repiteo Repiteo merged commit c3d1abb into godotengine:master Oct 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 23, 2025

Thanks! Congratulations on your first merged contribution! 🎉

@oxeron
Copy link
Contributor Author

oxeron commented Oct 23, 2025

Yahoo, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

POT file list does not update when deleting a scene

4 participants

X Tutup