X Tutup
Skip to content

Make BlendSpace selection tool consistent with StateMachine/BlendTree functionality#109792

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
vaner-org:blendspace-better-cursor
Oct 17, 2025
Merged

Make BlendSpace selection tool consistent with StateMachine/BlendTree functionality#109792
Repiteo merged 1 commit intogodotengine:masterfrom
vaner-org:blendspace-better-cursor

Conversation

@vaner-org
Copy link
Contributor

This is another in a series of pull requests that aim to enhance the usability of AnimationTree.

For BlendSpace1D and BlendSpace2D, this commit:

  • Changes the default tool to the select cursor, more in line with the default in BlendTree and StateMachine.
  • Changes the select cursor tool to be a hybrid, with support for Shift+LMB dragging to move the blend position cursor, just like how StateMachine's can create transitions.
  • Changes the order of the tools in the editor's toolbar to be how they are in StateMachine: LMB, RMB, Shift+LMB.
blendspace-better-cursor.mp4

My rationale is that adding and moving points occupies most of the user's time in the BlendSpace editor, whereas blending position is mostly expected to be changed at runtime. Also, the default tool being the blend position cursor causes constant friction when navigating through nested nodes.

@TokageItLab
Copy link
Member

TokageItLab commented Oct 3, 2025

Need to rebase or force push with new hash to re-run failed (maybe timeout by network error) test job.

@vaner-org vaner-org force-pushed the blendspace-better-cursor branch from 54c43a8 to 79b45ac Compare October 4, 2025 04:05
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looking over these, I think these are sensible UX changes as far as this particular UI goes. LGTM 👍

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Oct 17, 2025
@Repiteo Repiteo merged commit d5942cf into godotengine:master Oct 17, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Ready for review to Done in Animation Team Issue Triage Oct 17, 2025
@Repiteo
Copy link
Contributor

Repiteo commented Oct 17, 2025

Thanks!

@TokageItLab
Copy link
Member

TokageItLab commented Nov 10, 2025

This is causing the error reported in #112596. I'm not sure why the editor change is causing a node error, but the bound argument changed in this PR or some initializations might be incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup