Compatibility: Improve ASTC extension detecting#109778
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 19, 2025
Merged
Compatibility: Improve ASTC extension detecting#109778Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Member
|
Is |
Contributor
Author
|
clayjohn
approved these changes
Sep 2, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://developer.arm.com/documentation/102162/0430/Using-ASTC-with-graphics-APIs and https://registry.khronos.org/OpenGL/extensions/OES/OES_texture_compression_astc.txt ASTC extensions are packaged in the following 'tiers':
GL_KHR_texture_compression_astc_ldr- 2d, LDR only.GL_KHR_texture_compression_astc_sliced_3d- 2d and sliced 3d, LDR only,GL_KHR_texture_compression_astc_hdr- 2d and sliced 3d, LDR and HDR,GL_OES_texture_compression_astc- 2d, sliced 3d, volumetric 3d, LDR and HDR ('full'),TODO:
GL_KHR_texture_compression_astc, so I've decided to remove it. It has been present in the codebase since ASTC was first implemented in the engine, so it needs to be confirmed whether devices actually report it.WEBGL_compressed_texture_astccan support both LDR and HDR profiles, and the functiongetSupportedProfilesmay be used to query them.