Core: Integrate semantic constants in math structs#109744
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 16, 2025
Merged
Core: Integrate semantic constants in math structs#109744Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Calinou
approved these changes
Aug 18, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Code looks good to me.
I agree this makes sense to make those constants somewhat closer to the Godot API in feel.
AThousandShips
approved these changes
Aug 19, 2025
- Excludes self-explanatory constants (ZERO, ONE, etc)
Repiteo
force-pushed
the
core/math-constants-semantic
branch
from
5a27ac7 to
84c0ec0
Compare
aaronfranke
approved these changes
Aug 20, 2025
Member
aaronfranke
left a comment
aaronfranke
left a comment
There was a problem hiding this comment.
I am in favor of this (or I should say, at least this), and the code looks good to me.
ProfessorOctopus
pushed a commit
to ProfessorOctopus/godot
that referenced
this pull request
Sep 17, 2025
…s-semantic Core: Integrate semantic constants in math structs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A variation of the above PR which integrates the changes discussed in the core meeting: semantic constants only! As such, this excludes self-explanatory constants (
ZERO,ONE, etc). Opted for a separate PR in case we want to revisit the more broad approach, without compromising the narrower scope which was already given a thumbs-up