FindInFiles: Allow replacing individual results#109727
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 23, 2025
Merged
FindInFiles: Allow replacing individual results#109727Repiteo merged 1 commit intogodotengine:masterfrom
FindInFiles: Allow replacing individual results#109727Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
FindInFiles: Allow replace individual resultsFindInFiles: Allow replacing individual results
kitbdev
approved these changes
Sep 17, 2025
Contributor
kitbdev
left a comment
There was a problem hiding this comment.
Looks good, works as expected.
c28852e to
aa6ac02
Compare
aa6ac02 to
b79ba11
Compare
Contributor
Author
KoBeWi
reviewed
Sep 19, 2025
b79ba11 to
a3f657b
Compare
Contributor
|
The icon looks good, tested in both light and dark themes. One thing I noticed is that this doesn't work with the check buttons on the left. For individual items this is fine, but for entire files that have some checked and some unchecked it may be unexpected. |
Contributor
Author
Yes, this is expected. |
Contributor
|
I think making the tooltip more accurate is a good idea. |
a3f657b to
3eebd52
Compare
Contributor
Author
3eebd52 to
221f1f4
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Video from proposal:
godot.windows.editor.x86_64_TGdVAEKk85.mp4
Closes godotengine/godot-proposals#12860