X Tutup
Skip to content

FindInFiles: Allow replacing individual results#109727

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
arkology:replace-individual
Oct 23, 2025
Merged

FindInFiles: Allow replacing individual results#109727
Repiteo merged 1 commit intogodotengine:masterfrom
arkology:replace-individual

Conversation

@arkology
Copy link
Contributor

Video from proposal:

godot.windows.editor.x86_64_TGdVAEKk85.mp4

Closes godotengine/godot-proposals#12860

@arkology arkology requested a review from a team as a code owner August 18, 2025 10:42
@AThousandShips AThousandShips changed the title FindInFiles: Allow replace individual results FindInFiles: Allow replacing individual results Aug 18, 2025
@AThousandShips AThousandShips added this to the 4.x milestone Aug 18, 2025
@kitbdev kitbdev modified the milestones: 4.x, 4.6 Sep 17, 2025
Copy link
Contributor

@kitbdev kitbdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, works as expected.

@arkology arkology requested a review from a team as a code owner September 19, 2025 20:01
@arkology
Copy link
Contributor Author

Now with new icon:

image

@kitbdev
Copy link
Contributor

kitbdev commented Sep 22, 2025

The icon looks good, tested in both light and dark themes.

One thing I noticed is that this doesn't work with the check buttons on the left. For individual items this is fine, but for entire files that have some checked and some unchecked it may be unexpected.

@arkology
Copy link
Contributor Author

One thing I noticed is that this doesn't work with the check buttons on the left. For individual items this is fine, but for entire files that have some checked and some unchecked it may be unexpected.

Yes, this is expected.
I could rephrase tooltip if necessary: "Replace all matches in file" instead of just "Replace"

@kitbdev
Copy link
Contributor

kitbdev commented Sep 22, 2025

I think making the tooltip more accurate is a good idea.

@arkology
Copy link
Contributor Author

Done :)

godot windows editor dev x86_64_Y227resDf4

@Repiteo Repiteo merged commit 084d5d4 into godotengine:master Oct 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 23, 2025

Thanks!

@arkology arkology deleted the replace-individual branch October 24, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to replace individual matches in Search Results

6 participants

X Tutup