X Tutup
Skip to content

Improve and reduce Game window sizing#109701

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
arkology:embed-options-menu
Nov 10, 2025
Merged

Improve and reduce Game window sizing#109701
Repiteo merged 1 commit intogodotengine:masterfrom
arkology:embed-options-menu

Conversation

@arkology
Copy link
Contributor

@arkology arkology commented Aug 17, 2025

Editor window minimum size, before:

image

Editor window minimum size, after:

godot windows editor dev x86_64_Grd95TdifW godot windows editor dev x86_64_dSR1TxVUXI

Closes godotengine/godot-proposals#12060

  1. Now the top bar is FlowContainer which means that there will be no issues with width.

  2. All embedding options were moved to single submenu and its icon is changed to see the difference between, for example, camera override options.

  3. I decided to move Toggle Selection Visibility button to the selection buttons section, since they are directly related.

  4. Panel where game window is placed on run is replaced with PanelContainer (there were sizing issues with it and the label inside it).

  5. There is a problem that the Floating Game Workspace does not increase the size of the window to the right, as it was before:

godot.windows.editor.dev.x86_64_RWaWyE2qZJ.mp4

If this is not ok, feel free to suggest how it can be fixed (same is valid for another changes I made).

@arkology arkology requested review from a team as code owners August 17, 2025 17:34
@arkology arkology requested a review from a team August 17, 2025 17:34
@YeldhamDev YeldhamDev added this to the 4.x milestone Aug 17, 2025
@arkology arkology force-pushed the embed-options-menu branch from 06a500f to ec7af92 Compare August 17, 2025 19:19
@arkology arkology requested a review from YeldhamDev August 17, 2025 19:19
Copy link
Member

@YeldhamDev YeldhamDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YeldhamDev YeldhamDev modified the milestones: 4.x, 4.6 Aug 17, 2025
@arkology arkology force-pushed the embed-options-menu branch from ec7af92 to d827a73 Compare August 18, 2025 05:46
@arkology arkology force-pushed the embed-options-menu branch 2 times, most recently from ff2dd0d to f2a4710 Compare August 18, 2025 12:28
@arkology arkology force-pushed the embed-options-menu branch from f2a4710 to fb01326 Compare October 7, 2025 18:38
@arkology
Copy link
Contributor Author

arkology commented Oct 7, 2025

@Repiteo
Copy link
Contributor

Repiteo commented Nov 9, 2025

Needs rebase

@arkology
Copy link
Contributor Author

Rebased and tested a bit again.

@Repiteo Repiteo merged commit 42cb935 into godotengine:master Nov 10, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move embedded window sizing buttons from main Game workspace toolbar to sub-menu

5 participants

X Tutup