X Tutup
Skip to content

Android: Only validate keystore relevant to current export mode#109568

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
syntaxerror247:export-keystore-check
Sep 16, 2025
Merged

Android: Only validate keystore relevant to current export mode#109568
Repiteo merged 1 commit intogodotengine:masterfrom
syntaxerror247:export-keystore-check

Conversation

@syntaxerror247
Copy link
Member

  • Debug builds skip release keystore validation.
  • Release builds skip debug keystore validation.

Fixes #109551

- Debug builds skip release keystore validation.
- Release builds skip debug keystore validation.
@syntaxerror247 syntaxerror247 requested a review from a team as a code owner August 13, 2025 08:08
@syntaxerror247 syntaxerror247 added this to the 4.x milestone Aug 13, 2025
@syntaxerror247 syntaxerror247 added bug platform:android topic:export cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release labels Aug 13, 2025
@Repiteo Repiteo modified the milestones: 4.x, 4.6 Aug 13, 2025
@clayjohn clayjohn removed the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Sep 16, 2025
@Repiteo Repiteo merged commit 155c594 into godotengine:master Sep 16, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 16, 2025

Thanks!

@syntaxerror247 syntaxerror247 deleted the export-keystore-check branch September 16, 2025 18:03
@akien-mga
Copy link
Member

Cherry-picked for 4.5.1.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fail to export Android release when any of (but not all) debug keystore environment variables are set

5 participants

X Tutup