OpenXR: Safely set environment blend mode when rendering on a separate thread#109532
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 30, 2025
Merged
Conversation
dsnopek
force-pushed
the
openxr-api-environment-blend-mode-thread-safe
branch
from
8494600 to
da70105
Compare
m4gr3d
approved these changes
Aug 21, 2025
dsnopek
force-pushed
the
openxr-api-environment-blend-mode-thread-safe
branch
from
da70105 to
13a643d
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For OpenXR to work safely when Godot is rendering on a separate thread (by setting "Rendering" -> "Driver" -> "Thread Model" to "Safe" in Project Settings), any dynamic values we read from on the render thread need to be either protected by a mutex, or set via
RenderingServer::call_on_render_thread()Currently, in
OpenXR::end_frame()(which runs on the render thread) we're reading fromenvironment_blend_mode, which can be set directly on the main thread.This PR adds a new variable to
render_statethat will be read their instead, and sets it viaRenderingServer::call_on_render_thread()I've tested that this works on Quest 3, even for applications that were configured to start in passthrough mode by setting "Environment Blend Mode" to "Alpha" in project settings. They can go from passthrough to passthrough, without having a random opaque frame in-between (at least as far as I could tell :-)).