X Tutup
Skip to content

Move Lock View Rotation label logic out of process notification#109490

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
Open-Industry-Project:move-rotation-lock
Oct 23, 2025
Merged

Move Lock View Rotation label logic out of process notification#109490
Repiteo merged 1 commit intogodotengine:masterfrom
Open-Industry-Project:move-rotation-lock

Conversation

@ryevdokimov
Copy link
Contributor

@ryevdokimov ryevdokimov commented Aug 10, 2025

Requires and Includes: #109469

There is no reason to update this every frame.

image

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected (the update spinner no longer spins continuously when visible). Code looks good to me.

@ryevdokimov
Copy link
Contributor Author

Rebased since #109469 was merged

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Oct 23, 2025
@Repiteo Repiteo merged commit 80f4674 into godotengine:master Oct 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 23, 2025

Thanks!

@ryevdokimov ryevdokimov deleted the move-rotation-lock branch October 23, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup