Preserve mesh, material, and texture names in GLTF export#109475
Preserve mesh, material, and texture names in GLTF export#109475Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
|
I support this, but I am not able to review during the next week. @aaronfranke and @lyuma are around. |
|
Coincidentally I just made a PR for doing this with mesh names 2 days ago: #109421 Can you make sure that the code in your PR matches this for meshes, and works the same way for surface, material, and texture names? |
nikitalita
force-pushed
the
preserve-gltf-names
branch
from
75c05a2 to
010b525
Compare
Ok, I rebased on top of yours and left all your changes intact, and I added my changes for materials and images. |
nikitalita
force-pushed
the
preserve-gltf-names
branch
from
010b525 to
3d18069
Compare
|
4.5 is forked, so this could be reviewed and merged into master now. |
|
4.5 has not been forked yet, the documentation has but not the main repo |
nikitalita
force-pushed
the
preserve-gltf-names
branch
from
3d18069 to
7602b03
Compare
nikitalita
force-pushed
the
preserve-gltf-names
branch
from
7602b03 to
c26714f
Compare
nikitalita
force-pushed
the
preserve-gltf-names
branch
from
0455a1e to
a06bfbd
Compare
nikitalita
force-pushed
the
preserve-gltf-names
branch
from
a06bfbd to
b64a627
Compare
nikitalita
force-pushed
the
preserve-gltf-names
branch
from
b64a627 to
74a03b4
Compare
github-project-automation
bot
moved this from Ready for review
to Done
in Asset Pipeline Issue Triage
|
Thanks! |
5 participants
When serializing a Godot scene to a GLTF document, the original mesh, material, and texture names are not currently being serialized. This makes it difficult to compare exported scenes with the original and verify that GLTF exports are accurate. This changes the serialization process such that if the meshes, materials, and textures have names, we use them and we save them to the document.