Fix cinematic preview causing the editor redraw continuously and aspect ratio not updating in camera preview#109469
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Aug 12, 2025
Conversation
ryevdokimov
force-pushed
the
fix-previews
branch
from
b7b5901 to
80f8e08
Compare
…ct ratio not updating in camera preview
ryevdokimov
force-pushed
the
fix-previews
branch
from
80f8e08 to
edee07b
Compare
AThousandShips
added
bug
topic:editor
topic:3d
performance
cherrypick:4.4
Contributor
|
Thanks! |
atlasapplications
pushed a commit
to atlasapplications/godot
that referenced
this pull request
Aug 13, 2025
Fix cinematic preview causing the editor redraw continuously and aspect ratio not updating in camera preview
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #101499
Moves the logic out of notification.
The aspect ratio yellow rectangle updating worked with cinematic preview because of the bug (but didn't work with just regular preview camera), this PR also makes it work with both after the redraw fix by making it driven by the camera properties changing.
2025-08-09.21-20-19.mp4