Fix node can't be rotated by holding ctrl/command while in select mode#109465
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Aug 12, 2025
Merged
Conversation
ryevdokimov
force-pushed
the
fix-ctrl-command-rotate
branch
from
11fbd99 to
0ff964c
Compare
winston-yallow
previously requested changes
Aug 11, 2025
ryevdokimov
force-pushed
the
fix-ctrl-command-rotate
branch
from
0ff964c to
1672b69
Compare
Contributor
winston-yallow
left a comment
winston-yallow
left a comment
There was a problem hiding this comment.
Tested this, and it works as expected! Thanks for the quick fix 🚀
I did not review the code in depth though as there are people who know C++ better than me 😁
Calinou
approved these changes
Aug 11, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #109440
This could be less complicated if #105790 was implemented, but we're a bit late in the release cycle, so
altfunctionality was maintained in this PR hence a lot of checks. I made it a bit more verbose so it's easier to digest and change in the future if needed.