Add icon & clear button to Select Method dialog search bar#109384
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 13, 2025
Merged
Add icon & clear button to Select Method dialog search bar#109384Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
arkology
reviewed
Aug 7, 2025
Contributor
The initial AccessKit PR contains such changes, so I assume the answer is "yes". |
KoBeWi
reviewed
Aug 7, 2025
Giganzo
force-pushed
the
property_selector_search_box
branch
from
ed8a28b to
b2e314e
Compare
KoBeWi
approved these changes
Aug 7, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Search bar in the Select Method dialog was missing clear button and icon like other search/filter boxes have in the editor.
Before:
After:
Saw that other search boxes had set_accessibility_name set. So added this here as well, is this correct?