Move advanced toggle state out of export presets#109356
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 23, 2025
Merged
Move advanced toggle state out of export presets#109356Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Calinou
approved these changes
Aug 6, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
For those wondering, there are a few precedents of editor setting names being in no section and starting with an underscore. For example:
godot/editor/docks/scene_tree_dock.cpp
Line 1642 in c81fd6c
Contributor
|
Thanks! |
Contributor
|
@Repiteo @KoBeWi this PR introduced an error on engine startup. It is also happening at current code of master branch. I checked the This is Godot Engine v4.6.dev.custom_build.ab6c6eece |
Member
Author
|
I don't see any error. Make a reproduction project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editor export dialog got an advanced toggle some time ago, but for whatever reason the state of this button is stored inside the preset itself.
This PR moves it to a hidden editor setting, so the state is stored globally for all presets and projects. The method
are_advanced_options_enabled()is still there, now it just returns the value of the setting. Though #108169 would be nice to have here .-.