X Tutup
Skip to content

[Copyright] Fix spelling of license#109339

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
AThousandShips:fix_copyright
Sep 24, 2025
Merged

[Copyright] Fix spelling of license#109339
Repiteo merged 1 commit intogodotengine:masterfrom
AThousandShips:fix_copyright

Conversation

@AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Aug 5, 2025 •
edited
Loading

When using automated checks for listing licenses this fails to look up without fixing the spelling as only BSD-3-clause is stored in the Engine entries.

Discovered while working on an automated listing of licenses for a game project

This was the only entry I could find, but there might be other ones

@AThousandShips AThousandShips added this to the 4.5 milestone Aug 5, 2025
@AThousandShips AThousandShips requested a review from a team as a code owner August 5, 2025 16:30
@AThousandShips AThousandShips added bug topic:codestyle cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release labels Aug 5, 2025
@Calinou
Copy link
Member

Calinou commented Aug 5, 2025

https://spdx.org/licenses/ says it should be BSD-3-Clause with an uppercase C though. Are we using lowercase c elsewhere?

@AThousandShips
Copy link
Member Author

AThousandShips commented Aug 6, 2025 •
edited
Loading

Yes everywhere else (17 cases), and the license itself is listed in Engine.get_license_info in lower case, the entry in this file is in lower case here:

godot/COPYRIGHT.txt

Lines 883 to 909 in c81fd6c

License: BSD-3-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
.
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
.
3. Neither the name of the copyright holder nor the names of its
contributors may be used to endorse or promote products derived from
this software without specific prior written permission.
.
THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
SUCH DAMAGE.

Same with the 2-clause

godot/COPYRIGHT.txt

Lines 861 to 881 in c81fd6c

License: BSD-2-clause
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
.
* Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
.
* Redistributions in binary form must reproduce the above copyright notice,
this list of conditions and the following disclaimer in the documentation
and/or other materials provided with the distribution.
.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

I can alternatively alter all cases to be upper case but they have to match the entries

@AThousandShips
[Copyright] Fix spelling of license
0c4a00b 
When using automated checks for listing licenses this fails to look up
without fixing the spelling as only `BSD-3-clause` is stored in the
`Engine` entries.
@Repiteo Repiteo added the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Sep 5, 2025
@Repiteo Repiteo modified the milestones: 4.5, 4.6 Sep 5, 2025
@AThousandShips AThousandShips mentioned this pull request Sep 19, 2025
Closed
@Repiteo Repiteo merged commit 89fea8e into godotengine:master Sep 24, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 24, 2025

Thanks!

@AThousandShips
Copy link
Member Author

AThousandShips commented Sep 24, 2025

Thank you!

@AThousandShips AThousandShips deleted the fix_copyright branch September 24, 2025 18:00
@akien-mga akien-mga removed the cherrypick:4.4 Considered for cherry-picking into a future 4.4.x release label Jan 16, 2026
@akien-mga
Copy link
Member

akien-mga commented Jan 16, 2026

Cherry-picked for 4.5.2.

@akien-mga akien-mga removed the cherrypick:4.5 Considered for cherry-picking into a future 4.5.x release label Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Calinou Calinou Calinou approved these changes

Assignees

No one assigned

Labels

bug topic:codestyle

Projects

None yet

Milestone

4.6

Development

Successfully merging this pull request may close these issues.

The copyright license name is incorrect.

4 participants

@AThousandShips @Calinou @Repiteo @akien-mga
X Tutup