Avoid unnecessary updates in TileMapLayer #109243
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 25, 2025
Merged
Conversation
groud
requested changes
Aug 4, 2025
precup
force-pushed
the
tile-map-optimizations
branch
2 times, most recently
from
9ecc131 to
e67a6ec
Compare
precup
force-pushed
the
tile-map-optimizations
branch
from
e67a6ec to
adfb0d8
Compare
precup
changed the title
TileMapLayer::set_cellTileMapLayer
groud
approved these changes
Aug 11, 2025
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Significantly improves #105957, although I'm not sure if it's fast enough to be considered fixed or not.
Looking at the flamegraph, there were two major sections that seemed like low hanging fruit.
The first was that if
navigation_enabledisfalse, then any update will cause every cell to clear its navigation, which isn't needed if navigation wasn't already in use.The second was a bunch of overhead from the red black tree used to sort quadrants. I tried out
LocalVectorandSortArrayinstead to see how it would compare, and it's uglier but significantly faster.Numbers
With no optimizations, I get ~260 ms Physics spikes.
With the first optimization, I get 42 ms Physics spikes.
With both optimizations, I get 28 ms Physics spikes.
At that point, the process time dominates.