X Tutup
Skip to content

ThemeEditor: Reorganize/fix UI to make it fit in editor (at its minimum size in single-window mode) better#109237

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
arkology:theme-editor-ui
Nov 10, 2025
Merged

ThemeEditor: Reorganize/fix UI to make it fit in editor (at its minimum size in single-window mode) better#109237
Repiteo merged 1 commit intogodotengine:masterfrom
arkology:theme-editor-ui

Conversation

@arkology
Copy link
Contributor

@arkology arkology commented Aug 2, 2025

Replace text for add preview / close buttons with icons, remove theme preview custom minimum width, fix "Manage Items" window size in single-window mode and editor window at minimum size.
This allows to reduce minimum size of ThemeEditor, improving (partially fixing) the use of non-standard editor layouts (for example, 2 columns for left dock and 1 column for right dock) without panels pushed out of screen.

4.5 beta 3 PR
Godot_v4 5-beta3_win64_KyEbXAurPz godot windows editor dev x86_64_8hsh5LIC4U
Godot_v4.5-beta3_win64_cMxgLUPIbN.mp4

Related to #102301


UPD: Now it looks a bit different (after addressing @KoBeWi feedback) and also closes godotengine/godot-proposals#9372:

godot.windows.editor.x86_64_pcjY8XFJFD.mp4

@arkology arkology requested review from a team as code owners August 2, 2025 14:07
@AThousandShips AThousandShips added this to the 4.x milestone Aug 4, 2025
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, theme editor seems to be usable at min. window size.

@bruvzg bruvzg modified the milestones: 4.x, 4.6 Aug 6, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Aug 6, 2025

This stray separator looks odd when there is much space:
image
Maybe you could add icon to Manage Elements, to act as separator?

These 2 Add buttons next to each other are also questionable:
image
idk how to improve it though.

@arkology
Copy link
Contributor Author

arkology commented Aug 6, 2025

This stray separator looks odd when there is much space:
image
Maybe you could add icon to Manage Elements, to act as separator?

This is questionable, for me it does not look odd. I could add icon, but it will eat more space I just freed and I'm not sure which icon to use.

These 2 Add buttons next to each other are also questionable:
image
idk how to improve it though.

Agreed. I could move "Add preview" button to the left of preview tabs, but it will also look odd (tested it before).

@arkology
Copy link
Contributor Author

arkology commented Aug 7, 2025

These 2 Add buttons next to each other are also questionable:
image
idk how to improve it though.

I was looking through the list of issues I had saved earlier (and was interested in) and found this godotengine/godot-proposals#9372. So actually I could make this button flat! @KoBeWi what do you think?

@KoBeWi
Copy link
Member

KoBeWi commented Aug 7, 2025

Flat and next to the last tab, like in the proposal and scene tabs. That would be nice.

…imum size in single-window mode) better

Replace text for add/close buttons with icons, remove theme preview custom minimum width, fix "Manage Items" window size in single-window mode and editor window at minimum size. Also theme preview tab looks like scenes tab.
This allows to reduce minimum size of `ThemeEditor`, improving (partially fixing) the use of non-standard editor layouts (for example, 2 columns for left dock and 1 column for right dock) without panels pushed out of screen.
@Repiteo Repiteo merged commit ac8991c into godotengine:master Nov 10, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2025

Thanks!

@arkology arkology deleted the theme-editor-ui branch November 10, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the theme editor's Add Preview button

5 participants

X Tutup