Use safe ObjectID for mouse over controls.#109063
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 18, 2025
Merged
Conversation
bruvzg
force-pushed
the
safe_mouseover_ids
branch
from
917f949 to
d39c1d0
Compare
jerome-ceccato
left a comment
jerome-ceccato
left a comment
There was a problem hiding this comment.
Can confirm that this fixes the issue that I reported in #109053 in both the MRP and my actual project where I encountered this crash originally.
Thanks for your work!
Repiteo
approved these changes
Nov 18, 2025
bruvzg
force-pushed
the
safe_mouseover_ids
branch
from
d39c1d0 to
179d1b7
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109053
Use
ObjectIDs instead of raw pointer for mouse over control states to ensure it is safe to use in case control was deleted in the mouse enter/exit notification callback.