Add confirmation dialog to filesystem dock when moving or copying files#109017
Conversation
|
The dialog always says "Move selected files?", even when dragging directories. Also the dialog looks rather barebones: |
|
@KoBeWi Thanks for your feedback! I've adjusted the message and removed the meta data. |
KoBeWi
left a comment
KoBeWi
left a comment
There was a problem hiding this comment.
Some minor details left, but functionality-wise looks good.
nubels
force-pushed
the
file-system-confirmation-dialog
branch
from
631357d to
3d764e5
Compare
|
Sorry for that, this is my first time. I hope it's fixed now. |
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
|
Thanks! Congratulations on your first merged contribution! 🎉 |
|
I understand the good intentions of this issue but this is a real pain for me. I would strongly suggest adding at least the option to turn it off in the editor settings. I am rolling back to 4.5 for now. |
ghost
mentioned this pull request
|
This is also a great annoyance for me. When it's large files having the confirmation makes sense, but for people like me who are constantly moving only one or two things at a time just because I didn't save it in exactly the right folder it gets to be extremely annoying. Even more so when I need to do a restructuring of my files. I don't need a confirmation for the action I'm currently doing, and all this does is make me want to handle it out of engine. Any errors caused by the latter method would be preferable to a pop up every single action. |
|
Thanks for the feedback, I will open a PR adding a checkbox soon. |
7 participants
Closes godotengine/godot-proposals#7862.
This adds a confirmation dialog to the file system when the user moves or copies one or more files.
As discussed in the PR, the option to disable the confirmation was not added, and the dialog shows where the files will be moved or copied to.