Do not zero elements and perform fast clear in HashMap#108932
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 17, 2025
Merged
Do not zero elements and perform fast clear in HashMap#108932Repiteo merged 1 commit intogodotengine:masterfrom
HashMap#108932Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Ivorforce
approved these changes
Jul 26, 2025
AThousandShips
changed the title
HashMapHashMap
Contributor
|
Needs rebase |
Nazarwadim
force-pushed
the
hash_map_final_optimization
branch
from
b54bc88 to
e6bc3fa
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is optimizations from #90082.
The first optimization is that it is not necessary for the element pointers to be null, since the hashes are already null.
Second, the elements are cleared, such as in a linked list, and then the hashes and pointers to the elements are freed. This will eliminate iteration over hashes and elements and result in the elements being freed in the order they were inserted.