Add project setting and build option to disable override.cfg and related CLI arguments.#108818
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Oct 8, 2025
Merged
Add project setting and build option to disable override.cfg and related CLI arguments.#108818Repiteo merged 1 commit intogodotengine:masterfrom
override.cfg and related CLI arguments.#108818Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
adamscott
reviewed
Aug 1, 2025
Member
adamscott
left a comment
adamscott
left a comment
There was a problem hiding this comment.
The double-negation really trips me off.
#ifndef OVERRIDE_DISABLEDI think instead we should use OVERRIDE_ENABLED instead and put the default build value to true. It makes it clear that the code inside the #ifdef is really when overrides are enabled.
Member
Author
|
Switched it to |
adamscott
approved these changes
Aug 1, 2025
Member
adamscott
left a comment
adamscott
left a comment
There was a problem hiding this comment.
Overall, it seems OK with me!
adamscott
added
the
cherrypick:4.4
Repiteo
added
the
cherrypick:4.5
Repiteo
approved these changes
Sep 16, 2025
Contributor
Repiteo
left a comment
Repiteo
left a comment
There was a problem hiding this comment.
Implementation looks good, but we should be marking our #endif ranges explicitly
…lated CLI arguments.
akien-mga
removed
cherrypick:4.4
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvaged remaining parts of #76161 (PCK encryption for Android is already implemented).
application/config/disable_project_settings_overrideproject setting to disableoverride.cfgand--script,--main-looparguments.disable_overridesbuild option to disable project setting overrides and more CLI options.Partially implements godotengine/godot-proposals#12036
Fixes godotengine/godot-proposals#12037