[macOS] Use "file" icon for bundles in the file dialogs.#108804
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 22, 2025
Merged
[macOS] Use "file" icon for bundles in the file dialogs.#108804Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
KoBeWi
approved these changes
Jul 23, 2025
Member
KoBeWi
left a comment
KoBeWi
left a comment
There was a problem hiding this comment.
I didn't test, but the code looks fine.
adamscott
approved these changes
Jul 24, 2025
Calinou
approved these changes
Jul 31, 2025
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Tested locally, it works as expected. Code looks good to me.
Note that this doesn't display actual app icons, just a generic file icon.
Member
Author
|
We can get system icons, but it might look out of place, and the primary purpose of this PR is better display for non-app bundles, like |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in file dialogs can detect bundles and allow selecting them as files, but were using folder icon for them, which might be confusing.
This PR changes it to use generic file icon (but with folder color) instead.
AppIcon.iconis bundle this screenshot: