Fix clear color being incorrect in Environment background with HDR 2D.#108682
Merged
akien-mga merged 1 commit intogodotengine:masterfrom Nov 27, 2025
Merged
Fix clear color being incorrect in Environment background with HDR 2D.#108682akien-mga merged 1 commit intogodotengine:masterfrom
Environment background with HDR 2D.#108682akien-mga merged 1 commit intogodotengine:masterfrom
Conversation
allenwp
force-pushed
the
98708-fix-clear-color-hdr2d
branch
from
c9dfd41 to
50bd636
Compare
allenwp
force-pushed
the
98708-fix-clear-color-hdr2d
branch
from
50bd636 to
b9ef2f0
Compare
allenwp
force-pushed
the
98708-fix-clear-color-hdr2d
branch
from
b9ef2f0 to
42d7090
Compare
allenwp
force-pushed
the
98708-fix-clear-color-hdr2d
branch
from
42d7090 to
f37edd5
Compare
clayjohn
approved these changes
Nov 27, 2025
Member
clayjohn
left a comment
clayjohn
left a comment
There was a problem hiding this comment.
Makes sense. This avoids converting to linear in the one other place where render_target_get_clear_request_color() is called which is in the 3D renderer. It sets up the default background color which has srgb_to_linear() called on it anyway
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98708
The function that this PR changes seems to only be called by
RendererSceneRenderRD::render_scene(used in the code path of the original bug report) andRendererCanvasRenderRD::_render_batch_items. One of those requires modifying the colour transfer function, but the other doesn't.I've also added two
@paramcomments regarding these sorts of issues inrendering_device.h.