X Tutup
Skip to content

[EditorExportPlatform] Move initialization to a dedicated method.#108658

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:ed_pl_init
Sep 30, 2025
Merged

[EditorExportPlatform] Move initialization to a dedicated method.#108658
Repiteo merged 1 commit intogodotengine:masterfrom
bruvzg:ed_pl_init

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 16, 2025

See #108484 (comment), previously EditorNode::get_singleton() was sufficient to prevent unnecessary init and thread creation when CLI doctool was used, but seems like editor is instantiating plugins to update docs in the runtime as well.

Note: will NOT fix. #108484

@bruvzg bruvzg added this to the 4.x milestone Jul 16, 2025
@bruvzg bruvzg requested review from a team as code owners July 16, 2025 05:58
@bruvzg bruvzg requested a review from a team as a code owner July 16, 2025 05:58
@bruvzg bruvzg requested a review from a team July 16, 2025 05:58
@bruvzg bruvzg requested a review from a team as a code owner July 16, 2025 05:58
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

@deralmas
Copy link
Contributor

Note: will NOT fix #108484

note that it still got tagged due to the "fix" keyword so you gotta reopen the issue when this gets merged. Perhaps editing the message to remove the keyword might work too.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Jul 22, 2025
@Repiteo Repiteo merged commit 5240f1c into godotengine:master Sep 30, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 30, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup