SCons: Ensure CPPDEFINES is properly utilized#108613
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Sep 16, 2025
Merged
SCons: Ensure CPPDEFINES is properly utilized#108613Repiteo merged 1 commit intogodotengine:masterfrom
CPPDEFINES is properly utilized#108613Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
ProfessorOctopus
pushed a commit
to ProfessorOctopus/godot
that referenced
this pull request
Sep 17, 2025
SCons: Ensure `CPPDEFINES` is properly utilized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of defines in SCons are declared in non-portable manner. This addresses that issue by guaranteeing
CPPDEFINESis used instead ofCCFLAGSwith compiler-specific prefixes/suffixes.