X Tutup
Skip to content

Do not require editor restart when changing manipulator gizmo opacity setting#108549

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
Open-Industry-Project:transform-gizmo-opacity-no-restart
Sep 23, 2025
Merged

Do not require editor restart when changing manipulator gizmo opacity setting#108549
Repiteo merged 1 commit intogodotengine:masterfrom
Open-Industry-Project:transform-gizmo-opacity-no-restart

Conversation

@ryevdokimov
Copy link
Contributor

Related: #108546

Previously you had this prompt:

image

Now:

2025-07-12.19-07-43.mp4

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@Repiteo Repiteo modified the milestones: 4.x, 4.6 Sep 23, 2025
@Repiteo Repiteo merged commit 3818888 into godotengine:master Sep 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Sep 23, 2025

Thanks!

@ryevdokimov ryevdokimov deleted the transform-gizmo-opacity-no-restart branch September 23, 2025 13:51
Comment on lines +8006 to +8010
void Node3DEditor::_on_editor_settings_changed() {
if (EditorSettings::get_singleton()->get_changed_settings().has("editors/3d/manipulator_gizmo_opacity")) {
update_gizmo_opacity();
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this doesn't use NOTIFICATION_EDITOR_SETTINGS_CHANGED?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup