X Tutup
Skip to content

Compatibility: Set GL_TEXTURE_MAX_LEVEL to the number of mipmaps#108528

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
BlueCube3310:compat-mip-limit
Oct 23, 2025
Merged

Compatibility: Set GL_TEXTURE_MAX_LEVEL to the number of mipmaps#108528
Repiteo merged 1 commit intogodotengine:masterfrom
BlueCube3310:compat-mip-limit

Conversation

@BlueCube3310
Copy link
Contributor

Required for implementing partial mipmap chains in images.

Sets the maximal LOD level in the Compatibility renderer to the actual number of mipmaps in an image. Setting it to 1000 functions correctly for now, but makes the texture not render when it has an incomplete mipmap chain.

@BlueCube3310 BlueCube3310 requested a review from a team as a code owner July 11, 2025 18:36
@BlueCube3310 BlueCube3310 added this to the 4.x milestone Jul 11, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@Repiteo Repiteo merged commit 90d407e into godotengine:master Oct 23, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 23, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup