X Tutup
Skip to content

Remove unnecessary newlines from key tooltip#108404

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
KoBeWi:oldline
Dec 21, 2025
Merged

Remove unnecessary newlines from key tooltip#108404
akien-mga merged 1 commit intogodotengine:masterfrom
KoBeWi:oldline

Conversation

@KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 8, 2025

These newlines are applied onto last line of the tooltip and aren't visible (luckily tooltips ignore trailing newlines).
And that aside, they shouldn't be even part of the translated string, but outside, like in the parts above.

@KoBeWi KoBeWi added this to the 4.5 milestone Jul 8, 2025
@KoBeWi KoBeWi requested a review from a team as a code owner July 8, 2025 12:21
@AThousandShips
Copy link
Member

The other cases feature trailing newlines as well, except for TYPE_VALUE, might be good to clean all even though the translated string cases are the most critical as they're not just not rendered but affect the translation strings (though not critically)

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 8, 2025

Ok, I deleted other newlines too.
I originally noticed the invalid strings on Weblate, hence I only handled the translated ones.

@Repiteo Repiteo modified the milestones: 4.5, 4.6 Sep 8, 2025
@akien-mga
Copy link
Member

Needs rebase.

@akien-mga akien-mga merged commit 834c3c0 into godotengine:master Dec 21, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the oldline branch December 21, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup