SpinBox: Add a property to set whether custom_arrow_step rounds value#108335
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Nov 18, 2025
Merged
Conversation
beicause
force-pushed
the
SpinBox-property-arrow-rounds-value
branch
from
8faaa52 to
3a63e29
Compare
Member
|
Isn't this new property the same as setting arrow step to double arrow_step = get_custom_arrow_step() != 0.0 ? get_custom_arrow_step() : get_step();
if (custom_arrow_round && get_custom_arrow_step() != 0.0) {
...
} else {
set_value(get_value() + (p_up ? arrow_step : -arrow_step));You are checking whether arrow step is not 0, in addition to the new property. The |
beicause
force-pushed
the
SpinBox-property-arrow-rounds-value
branch
from
3a63e29 to
892d4c1
Compare
Contributor
Author
No, see the discussion #108196 (comment) |
KoBeWi
reviewed
Aug 27, 2025
KoBeWi
reviewed
Aug 27, 2025
beicause
force-pushed
the
SpinBox-property-arrow-rounds-value
branch
2 times, most recently
from
f45bd6a to
d9df79a
Compare
KoBeWi
approved these changes
Aug 27, 2025
Contributor
|
Needs rebase |
Repiteo
force-pushed
the
SpinBox-property-arrow-rounds-value
branch
from
d9df79a to
7668360
Compare
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a property to set whether
custom_arrow_steprounds value, to restore the behavior in 4.3. It is useful to avoid breadking original value when clicking the arrow.