Change preview methods to take Callable#108162
Conversation
|
Could we change the implementation internally but still keep the original method exposed as is? At the end of the day, fortunately, it's pretty easy to mitigate this issue by fetching a Callable's object and method name individually. |
|
You mean like, not exposing the new methods? Yeah, they don't need to be exposed. I mostly noticed it when doing #108147 |
|
Indeed, maybe slapping a huge "TODO" to have those methods use Callable as soon as it's reasonable to do so. |
KoBeWi
force-pushed
the
preview_simplication
branch
from
5202eb4 to
48f3c11
Compare
Mickeon
left a comment
Mickeon
left a comment
There was a problem hiding this comment.
Now that the change is internal this is more reasonable.
That aside, the PR is a pretty sweet clean-up of a very shoddy, likely legacy, part of the editor.
It may speed up things a little too, but that was not the goal. Seeing Variant being passed around for no reason was already painful enough.
|
Needs rebase |
KoBeWi
force-pushed
the
preview_simplication
branch
from
48f3c11 to
eae9ef2
Compare
|
Thanks! |
3 participants
In Godot 4 most methods moved from "object, method, userdata" combo to just use a single Callable. The only remaining one (I think) are preview methods:
queue_resource_previewandqueue_edited_resource_preview.For now the new methods are unexposed, and only used internally.