X Tutup
Skip to content

Replace spaces and use lowercase automatically for project manager tags#108125

Merged
Repiteo merged 1 commit intogodotengine:masterfrom
Calinou:project-manager-tags-auto-underscore-lowercase
Nov 18, 2025
Merged

Replace spaces and use lowercase automatically for project manager tags#108125
Repiteo merged 1 commit intogodotengine:masterfrom
Calinou:project-manager-tags-auto-underscore-lowercase

Conversation

@Calinou
Copy link
Member

@Calinou Calinou commented Jun 30, 2025

This makes the workflow of adding tags smoother by automatically using valid tag names, rather than showing error messages. This also strips edges when the field is submitted to avoid leading/trailing underscores.

@Calinou Calinou added this to the 4.x milestone Jun 30, 2025
@Calinou Calinou force-pushed the project-manager-tags-auto-underscore-lowercase branch from 30dd90d to 56b9ee0 Compare June 30, 2025 00:08
@Calinou Calinou force-pushed the project-manager-tags-auto-underscore-lowercase branch from 56b9ee0 to c11ede2 Compare July 23, 2025 22:03
@Calinou Calinou requested a review from a team July 23, 2025 22:03
@KoBeWi KoBeWi modified the milestones: 4.x, 4.6 Jul 28, 2025
@Calinou Calinou force-pushed the project-manager-tags-auto-underscore-lowercase branch from c11ede2 to adbe9df Compare August 1, 2025 16:52
@Repiteo
Copy link
Contributor

Repiteo commented Nov 13, 2025

Needs rebase

This makes the workflow of adding tags smoother by automatically
using valid tag names, rather than showing error messages.
This also strips edges when the field is submitted to avoid
leading/trailing underscores.
@Calinou Calinou force-pushed the project-manager-tags-auto-underscore-lowercase branch from adbe9df to afbefa6 Compare November 18, 2025 01:06
@Calinou
Copy link
Member Author

Calinou commented Nov 18, 2025

Rebased and tested again, it works as expected. Form validation now takes the spaces-to-underscores conversion into account (for the consecutive underscores check).

@Repiteo Repiteo merged commit 376a19e into godotengine:master Nov 18, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 18, 2025

Thanks!

@Calinou Calinou deleted the project-manager-tags-auto-underscore-lowercase branch November 18, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup